@mention autocomplete is overenthusiastic

User avatar
spacemonaut
Creature — Human Artificer
Posts: 487
Joined: 11 months ago
Answers: 6
Pronoun: they / them
Location: London
Has thanked: 265 times
Been thanked: 95 times

Post by spacemonaut » 3 weeks ago

The autocomplete for mentions is creating a bit of a problem. It will follow my text cursor around anytime as long as there's something resembling an @ mention anywhere earlier in the post. Note for example down here my text cursor is right at the end of the post and the autocomplete is still offered.
2020-06-11_09-22-14_firefox.png
(I got here by using the text-highlight quote on someone's post rather than hitting the quote button on the post.)

This is kind of a problem because I can't hit enter at all or else it tries to autocomplete that mention, but starting from where my cursor is at the time rather than where the mention is:
2020-06-11_09-22-23_firefox.png
But since the @ is still there, the autocomplete will still be following me around, meaning if I try to hit enter again, it just autocompletes yet again.
2020-06-11_09-22-30_firefox.png



Suggestion: The @ mention autocomplete should only be present while my cursor is inside the word following the @.

User avatar
Feyd_Ruin
Elder Vampire
Posts: 996
Joined: 1 year ago
Answers: 1
Pronoun: he / him
Has thanked: 46 times
Been thanked: 212 times
Contact:

Titles & Recognition

Post by Feyd_Ruin » 3 weeks ago

Eee.
I fixed it for regular quote, but it looks like I need a more substantial fix to hit all the corner cases. I'll look into it this afternoon. Apologies for the issues
Expand Signature
  « Ex cineribus nos renatus. »  

User avatar
spacemonaut
Creature — Human Artificer
Posts: 487
Joined: 11 months ago
Answers: 6
Pronoun: they / them
Location: London
Has thanked: 265 times
Been thanked: 95 times

Post by spacemonaut » 1 week ago

No problem, and thanks for working on it!!

User avatar
Feyd_Ruin
Elder Vampire
Posts: 996
Joined: 1 year ago
Answers: 1
Pronoun: he / him
Has thanked: 46 times
Been thanked: 212 times
Contact:

Titles & Recognition

Post by Feyd_Ruin » 1 week ago

@spacemonaut I think we're good to go.
Updated mentions to using tribute.js instead of atwho.js, which has eased quite a few things.

[card] is still using atwho, and thus still a bit overzealous, but it's on my list to redo a bit as well.
Expand Signature
  « Ex cineribus nos renatus. »  

User avatar
spacemonaut
Creature — Human Artificer
Posts: 487
Joined: 11 months ago
Answers: 6
Pronoun: they / them
Location: London
Has thanked: 265 times
Been thanked: 95 times

Post by spacemonaut » 1 week ago

@Feyd_Ruin

This is definitely not following me around anymore. : )

There's an issue to check out though:

1. Quote that post you wrote just above. Or this one, since I've put a mention at the top.
2. Type out a mention beneath it.
3. Hit TAB to autocomplete it. (Don't click the autocomplete menu, just hit tab.)

Expected: That mention gets autocompleted.
Actual: The post gets wiped starting at the first @ symbol and gets replaced with the mention you just autocompleted.

Try moving the mention around in order to test that it definitely wipes from wherever the first @ mention is.
Screenshot 2020-06-25 at 11.21.00.png
Screenshot 2020-06-25 at 11.21.02.png

Curiously as mentioned clicking in the autocomplete is just fine, so maybe the tab behaviour should do whatever that's doing.
Screenshot 2020-06-25 at 11.24.10.png

User avatar
Feyd_Ruin
Elder Vampire
Posts: 996
Joined: 1 year ago
Answers: 1
Pronoun: he / him
Has thanked: 46 times
Been thanked: 212 times
Contact:

Titles & Recognition

Post by Feyd_Ruin » 1 week ago

Meh. Silly whackamole.
I'll have to read the quote back from before.
Expand Signature
  « Ex cineribus nos renatus. »  

Post Reply Previous topicNext topic

Return to “Community Software Feedback and Bug Reports”